linux-kernel - Re: [PATCH 34/34] usb: typec: tcpm: fusb302: simplify getting the adapter of a client

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 13 Jun 2019 11:54:52 +0200
From:   Simon Horman <horms@...ge.net.au>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     Wolfram Sang <wsa+renesas@...g-engineering.com>,
        linux-i2c@...r.kernel.org,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 34/34] usb: typec: tcpm: fusb302: simplify getting the
 adapter of a client

On Sat, Jun 08, 2019 at 05:59:17AM -0700, Guenter Roeck wrote:
> On 6/8/19 3:56 AM, Wolfram Sang wrote:
> > We have a dedicated pointer for that, so use it. Much easier to read and
> > less computation involved.
> > 
> > Signed-off-by: Wolfram Sang <wsa+renesas@...g-engineering.com>
> 
> Reviewed-by: Guenter Roeck <linux@...ck-us.net>

Reviewed-by: Simon Horman <horms+renesas@...ge.net.au>

> 
> > ---
> > 
> > Please apply to your subsystem tree.
> > 
> >   drivers/usb/typec/tcpm/fusb302.c | 3 +--
> >   1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/drivers/usb/typec/tcpm/fusb302.c b/drivers/usb/typec/tcpm/fusb302.c
> > index 7302f7501ec9..c524088246ee 100644
> > --- a/drivers/usb/typec/tcpm/fusb302.c
> > +++ b/drivers/usb/typec/tcpm/fusb302.c
> > @@ -1697,13 +1697,12 @@ static int fusb302_probe(struct i2c_client *client,
> >   			 const struct i2c_device_id *id)
> >   {
> >   	struct fusb302_chip *chip;
> > -	struct i2c_adapter *adapter;
> > +	struct i2c_adapter *adapter = client->adapter;
> >   	struct device *dev = &client->dev;
> >   	const char *name;
> >   	int ret = 0;
> >   	u32 v;
> > -	adapter = to_i2c_adapter(client->dev.parent);
> >   	if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_I2C_BLOCK)) {
> >   		dev_err(&client->dev,
> >   			"I2C/SMBus block functionality not supported!\n");
> > 
>