linux-kernel - Re: [PATCH 11/34] media: i2c: tw9910: simplify getting the adapter of a client

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190613094846.bveex5pb7qfw7pmi@verge.net.au>
Date:   Thu, 13 Jun 2019 11:48:46 +0200
From:   Simon Horman <horms@...ge.net.au>
To:     Wolfram Sang <wsa+renesas@...g-engineering.com>
Cc:     linux-i2c@...r.kernel.org,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 11/34] media: i2c: tw9910: simplify getting the adapter
 of a client

On Sat, Jun 08, 2019 at 12:55:50PM +0200, Wolfram Sang wrote:
> We have a dedicated pointer for that, so use it. Much easier to read and
> less computation involved.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@...g-engineering.com>
> ---

Reviewed-by: Simon Horman <horms+renesas@...ge.net.au>

> 
> Please apply to your subsystem tree.
> 
>  drivers/media/i2c/tw9910.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/media/i2c/tw9910.c b/drivers/media/i2c/tw9910.c
> index 4d7cd736b930..a25a350b0ddc 100644
> --- a/drivers/media/i2c/tw9910.c
> +++ b/drivers/media/i2c/tw9910.c
> @@ -934,8 +934,7 @@ static int tw9910_probe(struct i2c_client *client,
>  {
>  	struct tw9910_priv		*priv;
>  	struct tw9910_video_info	*info;
> -	struct i2c_adapter		*adapter =
> -		to_i2c_adapter(client->dev.parent);
> +	struct i2c_adapter		*adapter = client->adapter;
>  	int ret;
>  
>  	if (!client->dev.platform_data) {
> -- 
> 2.19.1
>