linux-kernel - Re: [PATCH 2/8] EDAC/amd64: Support more than two controllers for chip selects handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190613141715.GD11598@zn.tnic>
Date:   Thu, 13 Jun 2019 16:17:15 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     "Ghannam, Yazen" <Yazen.Ghannam@....com>
Cc:     "linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/8] EDAC/amd64: Support more than two controllers for
 chip selects handling

On Fri, May 31, 2019 at 11:45:12PM +0000, Ghannam, Yazen wrote:
> diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c
> index 9fa2f205f05c..dd60cf5a3d96 100644
> --- a/drivers/edac/amd64_edac.c
> +++ b/drivers/edac/amd64_edac.c
> @@ -943,91 +943,101 @@ static void prep_chip_selects(struct amd64_pvt *pvt)
>  		pvt->csels[0].b_cnt = pvt->csels[1].b_cnt = 4;
>  		pvt->csels[0].m_cnt = pvt->csels[1].m_cnt = 2;
>  	} else if (pvt->fam >= 0x17) {
> -		pvt->csels[0].b_cnt = pvt->csels[1].b_cnt = 4;
> -		pvt->csels[0].m_cnt = pvt->csels[1].m_cnt = 2;
> +		int umc;
> +
> +		for_each_umc(umc) {
> +			pvt->csels[umc].b_cnt = 4;
> +			pvt->csels[umc].m_cnt = 2;
> +		}
> +

What is the purpose of the previous commit if you're changing it here in
the next one?

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.