linux-kernel - Re: [PATCH] usb: gadget: u_audio: Fixed variable declaration coding style issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190613145741.GA30884@vmlxhi-102.adit-jv.com>
Date:   Thu, 13 Jun 2019 16:57:41 +0200
From:   Eugeniu Rosca <erosca@...adit-jv.com>
To:     Jonas Stenvall <jonas.stenvall.umea@...il.com>
CC:     <balbi@...nel.org>, <gregkh@...uxfoundation.org>,
        <vladimir_zapolskiy@...tor.com>, <joshua_frkuska@...tor.com>,
        <linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Eugeniu Rosca <erosca@...adit-jv.com>,
        Eugeniu Rosca <rosca.eugeniu@...il.com>
Subject: Re: [PATCH] usb: gadget: u_audio: Fixed variable declaration coding
 style issue

Hi Jonas,

On Thu, Jun 13, 2019 at 11:34:33AM +0200, Jonas Stenvall wrote:
> Fixed a coding style issue, replacing unsigned with unsigned int.

No concerns on my side. FWIW, the 'bare use of unsigned' coding style
inconsistency is quite common in the USB gadget framework [1-2].

Depending on the feedback from the maintainers, I see below potential
outcomes for this patch (sorted by my personal estimation of chance):
 - we take it and we fix the rest on best-effort basis.
 - we kindly ask you to fix the issue globally in USB gadget space.
 - we don't care, as this is not a functional issue. We rather prefer to
   concentrate on functional problems.

Deciding on the above is a matter of maintainer's preference.

> 
> Signed-off-by: Jonas Stenvall <jonas.stenvall.umea@...il.com>
> ---
>  drivers/usb/gadget/function/u_audio.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

>From my end:

Reviewed-by: Eugeniu Rosca <erosca@...adit-jv.com>

[1] git grep -E "unsigned [^(int|short|char|long)]" -- drivers/usb/gadget/function | wc -l
32
[2] git grep -E "unsigned [^(int|short|char|long)]" -- drivers/usb/gadget | wc -l                    
99

-- 
Best Regards,
Eugeniu.