linux-kernel - Re: [PATCH] fault-inject: clean up debugfs file creation logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAC5umyhSiOo6aN=cy09MdH3R3qpWiaqk+b-1Onrc_Byqc19dAQ@mail.gmail.com>
Date:   Fri, 14 Jun 2019 01:24:46 +0900
From:   Akinobu Mita <akinobu.mita@...il.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] fault-inject: clean up debugfs file creation logic

2019年6月12日(水) 18:58 Greg Kroah-Hartman <gregkh@...uxfoundation.org>:
>
> There is no need to check the return value of a debugfs_create_file
> call, a caller should never change what they do depending on if debugfs
> is working properly or not, so remove the checks, simplifying the logic
> in the file a lot.
>
> Also fix up the error check for debugfs_create_dir() which was not
> returning NULL for an error, but rather a error pointer.
>
> Cc: Akinobu Mita <akinobu.mita@...il.com>
> Cc: linux-kernel@...r.kernel.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

Looks good.

Reviewed-by: Akinobu Mita <akinobu.mita@...il.com>