lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 14 Jun 2019 16:29:23 -0400 From: Sasha Levin <sashal@...nel.org> To: linux-kernel@...r.kernel.org, stable@...r.kernel.org Cc: Alex Shi <alex.shi@...ux.alibaba.com>, Shuah Khan <shuah@...nel.org>, Tejun Heo <tj@...nel.org>, Roman Gushchin <guro@...com>, Claudio Zumbo <claudioz@...com>, Claudio <claudiozumbo@...il.com>, linux-kselftest@...r.kernel.org, Shuah Khan <skhan@...uxfoundation.org>, Sasha Levin <sashal@...nel.org> Subject: [PATCH AUTOSEL 4.19 18/39] kselftest/cgroup: fix unexpected testing failure on test_core From: Alex Shi <alex.shi@...ux.alibaba.com> [ Upstream commit 00e38a5d753d7788852f81703db804a60a84c26e ] The cgroup testing relys on the root cgroup's subtree_control setting, If the 'memory' controller isn't set, some test cases will be failed as following: $sudo ./test_core not ok 1 test_cgcore_internal_process_constraint ok 2 test_cgcore_top_down_constraint_enable not ok 3 test_cgcore_top_down_constraint_disable ... To correct this unexpected failure, this patch write the 'memory' to subtree_control of root to get a right result. Signed-off-by: Alex Shi <alex.shi@...ux.alibaba.com> Cc: Shuah Khan <shuah@...nel.org> Cc: Tejun Heo <tj@...nel.org> Cc: Roman Gushchin <guro@...com> Cc: Claudio Zumbo <claudioz@...com> Cc: Claudio <claudiozumbo@...il.com> Cc: linux-kselftest@...r.kernel.org Cc: linux-kernel@...r.kernel.org Reviewed-by: Roman Gushchin <guro@...com> Acked-by: Tejun Heo <tj@...nel.org> Signed-off-by: Shuah Khan <skhan@...uxfoundation.org> Signed-off-by: Sasha Levin <sashal@...nel.org> --- tools/testing/selftests/cgroup/test_core.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tools/testing/selftests/cgroup/test_core.c b/tools/testing/selftests/cgroup/test_core.c index be59f9c34ea2..d78f1c5366d3 100644 --- a/tools/testing/selftests/cgroup/test_core.c +++ b/tools/testing/selftests/cgroup/test_core.c @@ -376,6 +376,11 @@ int main(int argc, char *argv[]) if (cg_find_unified_root(root, sizeof(root))) ksft_exit_skip("cgroup v2 isn't mounted\n"); + + if (cg_read_strstr(root, "cgroup.subtree_control", "memory")) + if (cg_write(root, "cgroup.subtree_control", "+memory")) + ksft_exit_skip("Failed to set memory controller\n"); + for (i = 0; i < ARRAY_SIZE(tests); i++) { switch (tests[i].fn(root)) { case KSFT_PASS: -- 2.20.1
Powered by blists - more mailing lists