linux-kernel - Re: [RFC 3/3] ata: sata_mv, avoid trigerrable BUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <75a4a778-6862-a0d0-1033-cd5fe57d6dbf@suse.cz>
Date:   Fri, 14 Jun 2019 10:33:01 +0200
From:   Jiri Slaby <jslaby@...e.cz>
To:     Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
        axboe@...nel.dk
Cc:     linux-kernel@...r.kernel.org, linux-ide@...r.kernel.org
Subject: Re: [RFC 3/3] ata: sata_mv, avoid trigerrable BUG_ON

On 14. 06. 19, 10:24, Sergei Shtylyov wrote:
>> --- a/drivers/ata/sata_mv.c
>> +++ b/drivers/ata/sata_mv.c
>> @@ -2098,12 +2098,10 @@ static int mv_qc_prep(struct ata_queued_cmd *qc)
>>            * non-NCQ mode are: [RW] STREAM DMA and W DMA FUA EXT, none
>>            * of which are defined/used by Linux.  If we get here, this
>>            * driver needs work.
>> -         *
>> -         * FIXME: modify libata to give qc_prep a return value and
>> -         * return error here.
>>            */
>> -        BUG_ON(tf->command);
>> -        break;
>> +        ata_port_err(ap, "%s: unsupported command: %d\n", __func__,
>> +                tf->command);
> 
>    I'd use "%x" here instead of "%d".

Hi, that makes sense. Fixed locally to %.2x as the commands are defined
as such. Waiting for more comments before [v2] :).

thanks,
-- 
js
suse labs