lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Fri, 14 Jun 2019 11:08:27 +0200
From:   Neil Armstrong <narmstrong@...libre.com>
To:     Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        linux-amlogic@...ts.infradead.org, khilman@...libre.com
Cc:     andrew@...n.ch, netdev@...r.kernel.org, linus.walleij@...aro.org,
        linux-kernel@...r.kernel.org, robin.murphy@....com,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 4/4] arm64: dts: meson: g12b: odroid-n2: add the
 Ethernet PHY reset line

On 12/06/2019 22:55, Martin Blumenstingl wrote:
> The reset line of the RTL8211F PHY is routed to the GPIOZ_15 pad.
> Describe this in the device tree so the PHY framework can bring the PHY
> into a known state when initializing it. GPIOZ_15 doesn't support
> driving the output HIGH (to take the PHY out of reset, only output LOW
> to reset the PHY is supported). The datasheet states it's an "3.3V input
> tolerant open drain (OD) output pin". Instead there's a pull-up resistor
> on the board to take the PHY out of reset. The GPIO itself will be set
> to INPUT mode to take the PHY out of reset and LOW to reset the PHY,
> which is achieved with the flags (GPIO_ACTIVE_LOW | GPIO_OPEN_DRAIN).
> 
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@...glemail.com>
> ---
>  arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
> index 4146cd84989c..f911bbdc4e70 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
> @@ -186,6 +186,10 @@
>  		/* Realtek RTL8211F (0x001cc916) */	
>  		reg = <0>;
>  		max-speed = <1000>;
> +
> +		reset-assert-us = <10000>;
> +		reset-deassert-us = <30000>;
> +		reset-gpios = <&gpio GPIOZ_15 (GPIO_ACTIVE_LOW | GPIO_OPEN_DRAIN)>;
>  	};
>  };
>  
> 

Thanks !

Acked-by: Neil Armstrong <narmstrong@...libre.com>
Tested-by: Neil Armstrong <narmstrong@...libre.com>

Powered by blists - more mailing lists