linux-kernel - Re: [PATCHv2 0/8] perf/x86: Rework msr probe interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190614102046.GB4325@krava>
Date:   Fri, 14 Jun 2019 12:20:46 +0200
From:   Jiri Olsa <jolsa@...hat.com>
To:     Jiri Olsa <jolsa@...nel.org>
Cc:     Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        "Liang, Kan" <kan.liang@...ux.intel.com>,
        Stephane Eranian <eranian@...gle.com>,
        Andy Lutomirski <luto@...nel.org>,
        lkml <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Andi Kleen <ak@...ux.intel.com>,
        Vince Weaver <vincent.weaver@...ne.edu>,
        Thomas Gleixner <tglx@...utronix.de>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCHv2 0/8] perf/x86: Rework msr probe interface

On Fri, May 31, 2019 at 02:09:50PM +0200, Jiri Olsa wrote:
> hi,
> following up on [1], [2] and [3], this patchset adds update
> attribute groups to pmu, factors out the MSR probe code and
> use it in msr,cstate* and rapl PMUs.
> 
> The functionality stays the same with one exception:
> for msr PMU: the event is not exported if the rdmsr return zero
> on event's msr, cstate* and rapl pmu functionality stays.
> 
> And also: ;-)
> > Somewhere along the line you lost the explanation of _why_ we're doing
> > this; namely: virt sucks.
> 
> Also available in:
>   git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git
>   perf/msr
> 
> Tested on snb and skylake servers.
> 
> v2 changes:
>   - checking zero rdmsr only for msr PMU events,
>     cstate* and rapl pmu functionality stays unchanged

ping

jirka

> 
> thanks,
> jirka
> 
> 
> [1] https://lore.kernel.org/lkml/20190301114250.GA23459@krava/
> [2] https://lore.kernel.org/lkml/20190318182116.17388-1-jolsa@kernel.org/
> [3] https://lore.kernel.org/lkml/20190512155518.21468-1-jolsa@kernel.org/
> ---
> Jiri Olsa (8):
>       perf/x86: Add msr probe interface
>       perf/x86/msr: Use new probe function
>       perf/x86/cstate: Use new probe function
>       perf/x86/rapl: Use new msr detection interface
>       perf/x86/rapl: Get rapl_cntr_mask from new probe framework
>       perf/x86/rapl: Get msr values from new probe framework
>       perf/x86/rapl: Get attributes from new probe framework
>       perf/x86/rapl: Get quirk state from new probe framework
> 
>  arch/x86/events/Makefile       |   2 +-
>  arch/x86/events/intel/cstate.c | 152 ++++++++++++++++++++++++++++++++++++++++------------------------------
>  arch/x86/events/intel/rapl.c   | 378 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++------------------------------------------------------------------------------------------------
>  arch/x86/events/msr.c          | 110 ++++++++++++++++++++++++++++-----------------------
>  arch/x86/events/probe.c        |  45 +++++++++++++++++++++
>  arch/x86/events/probe.h        |  29 ++++++++++++++
>  6 files changed, 391 insertions(+), 325 deletions(-)
>  create mode 100644 arch/x86/events/probe.c
>  create mode 100644 arch/x86/events/probe.h