linux-kernel - Re: [PATCH] ACPI: PM: Clear wake-up device GPEs before enabling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190614104511.GC2640@lahna.fi.intel.com>
Date:   Fri, 14 Jun 2019 13:45:11 +0300
From:   Mika Westerberg <mika.westerberg@...ux.intel.com>
To:     "Rafael J. Wysocki" <rjw@...ysocki.net>
Cc:     Furquan Shaikh <furquan@...gle.com>, Len Brown <lenb@...nel.org>,
        linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
        rajatja@...gle.com
Subject: Re: [PATCH] ACPI: PM: Clear wake-up device GPEs before enabling

On Thu, Jun 13, 2019 at 10:24:41PM +0200, Rafael J. Wysocki wrote:
> This patch may cause events to be missed if the GPE.  I guess what you reall mean is
> something like the patch below.
> 
> This should allow the kernel to see the events generated before the GPEs are
> implicitly enabled, but it should clear them for the explicit users of acpi_enable_gpe().
> 
> Mika, what do you think?

Looks good to me. I also tested this with two TBT systems (Skull Canyon
NUC and Dell XPS 9370) using ACPI hotplug and it did not cause any
problems if I boot the system with device connected.