linux-kernel - Re: [PATCH 2/2] tracing/uprobe: Fix obsolete comment on trace_uprobe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190614123210.GB16523@linux.vnet.ibm.com>
Date:   Fri, 14 Jun 2019 18:02:10 +0530
From:   Srikar Dronamraju <srikar@...ux.vnet.ibm.com>
To:     Eiichi Tsukata <devel@...ukata.com>
Cc:     rostedt@...dmis.org, mingo@...hat.com, mhiramat@...nel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] tracing/uprobe: Fix obsolete comment on
 trace_uprobe_create()

* Eiichi Tsukata <devel@...ukata.com> [2019-06-14 16:40:26]:

> Commit 0597c49c69d5 ("tracing/uprobes: Use dyn_event framework for
> uprobe events") cleaned up the usage of trace_uprobe_create(), and the
> function has been no longer used for removing uprobe/uretprobe.
> 

Agree

Reviewed-by: Srikar Dronamraju <srikar@...ux.vnet.ibm.com>

> Signed-off-by: Eiichi Tsukata <devel@...ukata.com>
> ---
>  kernel/trace/trace_uprobe.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
> index 7dc8ee55cf84..7860e3f59fad 100644
> --- a/kernel/trace/trace_uprobe.c
> +++ b/kernel/trace/trace_uprobe.c
> @@ -426,8 +426,6 @@ static int register_trace_uprobe(struct trace_uprobe *tu)
>  /*
>   * Argument syntax:
>   *  - Add uprobe: p|r[:[GRP/]EVENT] PATH:OFFSET [FETCHARGS]
> - *
> - *  - Remove uprobe: -:[GRP/]EVENT
>   */
>  static int trace_uprobe_create(int argc, const char **argv)
>  {
> -- 
> 2.21.0
> 

-- 
Thanks and Regards
Srikar Dronamraju