linux-kernel - re: RDMA: Clean destroy CQ in drivers do not return errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <68d62660-902c-ca49-20fd-32e92830faa7@canonical.com>
Date:   Fri, 14 Jun 2019 14:59:32 +0100
From:   Colin Ian King <colin.king@...onical.com>
To:     Leon Romanovsky <leonro@...lanox.com>,
        Gal Pressman <galpress@...zon.com>,
        Dennis Dalessandro <dennis.dalessandro@...el.com>,
        Doug Ledford <dledford@...hat.com>, linux-rdma@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org
Subject: re: RDMA: Clean destroy CQ in drivers do not return errors

Hi,

Static analysis with Coverity reported an issue with the following commit:

commit a52c8e2469c30cf7ac453d624aed9c168b23d1af
Author: Leon Romanovsky <leonro@...lanox.com>
Date:   Tue May 28 14:37:28 2019 +0300

    RDMA: Clean destroy CQ in drivers do not return errors

In function bnxt_re_destroy_cq() contains the following:

        if (!cq->umem)
                ib_umem_release(cq->umem);

Coverity detects this as a deference after null check on the null
pointer cq->umem:

"var_deref_model: Passing null pointer cq->umem to ib_umem_release,
which dereferences it"

Is the logic inverted on that null check?

Colin