linux-kernel - Re: [PATCH V1 1/2] mailbox: tegra: hsp: add noirq resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 14 Jun 2019 09:11:06 -0700
From:   Bitan Biswas <bbiswas@...dia.com>
To:     Thierry Reding <thierry.reding@...il.com>
CC:     Jassi Brar <jassisinghbrar@...il.com>,
        Thierry Reding <treding@...dia.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        <linux-kernel@...r.kernel.org>, <linux-tegra@...r.kernel.org>
Subject: Re: [PATCH V1 1/2] mailbox: tegra: hsp: add noirq resume



On 6/14/19 8:50 AM, Thierry Reding wrote:
> On Fri, Jun 14, 2019 at 05:35:33AM -0700, Bitan Biswas wrote:
>> Add noirq resume instead of resume callback for Tegra HSP. Tegra HSP
>> resume needs tegra_hsp_doorbell_startup() call to fix timeout error for
>> tegra_bpmp_transfer() during genpd resume noirq on jetson-tx2.
> 
> s/jetson-tx2/Jetson TX2/?
I shall replace the string "jetson-tx2" in commit description with 
"Jetson TX2".

> 
>>
>> Signed-off-by: Bitan Biswas <bbiswas@...dia.com>
>> ---
>>   drivers/mailbox/tegra-hsp.c | 12 ++++++++++--
>>   1 file changed, 10 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/mailbox/tegra-hsp.c b/drivers/mailbox/tegra-hsp.c
>> index 91f1a0c..f147374 100644
>> --- a/drivers/mailbox/tegra-hsp.c
>> +++ b/drivers/mailbox/tegra-hsp.c
>> @@ -771,10 +771,16 @@ static int tegra_hsp_probe(struct platform_device *pdev)
>>   	return 0;
>>   }
>>   
>> -static int __maybe_unused tegra_hsp_resume(struct device *dev)
>> +static int __maybe_unused tegra_hsp_noirq_resume(struct device *dev)
> 
> Maybe call this tegra_hsp_resume_noirq() to match the naming of the
> dev_pm_ops callback?
I shall rename tegra_hsp_noirq_resume back to tegra_hsp_resume.

> 
>>   {
>>   	struct tegra_hsp *hsp = dev_get_drvdata(dev);
>>   	unsigned int i;
>> +	struct tegra_hsp_doorbell *db;
>> +
>> +	list_for_each_entry(db, &hsp->doorbells, list) {
>> +		if (db && db->channel.chan)
>> +			tegra_hsp_doorbell_startup(db->channel.chan);
>> +	}
>>   
>>   	for (i = 0; i < hsp->num_sm; i++) {
>>   		struct tegra_hsp_mailbox *mb = &hsp->mailboxes[i];
>> @@ -786,7 +792,9 @@ static int __maybe_unused tegra_hsp_resume(struct device *dev)
>>   	return 0;
>>   }
>>   
>> -static SIMPLE_DEV_PM_OPS(tegra_hsp_pm_ops, NULL, tegra_hsp_resume);
>> +static const struct dev_pm_ops tegra_hsp_pm_ops = {
>> +	.resume_noirq   = tegra_hsp_noirq_resume,
> 
> There seems to be two extra spaces before that =.
Missed extra spaces. Shall fix.

-Thanks,
  Bitan