linux-kernel - Re: [PATCH v2] pwm: rockchip: Use of_clk_get_parent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5458953.i9kcuLIT7L@diego>
Date:   Sat, 15 Jun 2019 17:41:10 +0200
From:   Heiko Stübner <heiko@...ech.de>
To:     Kefeng Wang <wangkefeng.wang@...wei.com>
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Thierry Reding <thierry.reding@...il.com>
Subject: Re: [PATCH v2] pwm: rockchip: Use of_clk_get_parent_count()

Am Montag, 27. Mai 2019, 15:55:09 CEST schrieb Kefeng Wang:
> Use of_clk_get_parent_count() instead of open coding.
> 
> Cc: Thierry Reding <thierry.reding@...il.com>
> Cc: Heiko Stuebner <heiko@...ech.de>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@...wei.com>

Reviewed-by: Heiko Stuebner <heiko@...ech.de>

> ---
> v2:
> - add include <linux/of_clk.h>
>  drivers/pwm/pwm-rockchip.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pwm/pwm-rockchip.c b/drivers/pwm/pwm-rockchip.c
> index 4d99d468df09..d8f23daca290 100644
> --- a/drivers/pwm/pwm-rockchip.c
> +++ b/drivers/pwm/pwm-rockchip.c
> @@ -13,6 +13,7 @@
>  #include <linux/io.h>
>  #include <linux/module.h>
>  #include <linux/of.h>
> +#include <linux/of_clk.h>
>  #include <linux/of_device.h>
>  #include <linux/platform_device.h>
>  #include <linux/pwm.h>
> @@ -329,8 +330,8 @@ static int rockchip_pwm_probe(struct platform_device *pdev)
>  		}
>  	}
>  
> -	count = of_count_phandle_with_args(pdev->dev.of_node,
> -					   "clocks", "#clock-cells");
> +	count = of_clk_get_parent_count(pdev->dev.of_node);
> +
>  	if (count == 2)
>  		pc->pclk = devm_clk_get(&pdev->dev, "pclk");
>  	else
>