linux-kernel - Re: [PATCH] staging: android: fix style problem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190615173149.GA4914@kroah.com>
Date:   Sat, 15 Jun 2019 19:31:49 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Saiyam Doshi <saiyamdoshi.in@...il.com>
Cc:     dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        linaro-mm-sig@...ts.linaro.org
Subject: Re: [PATCH] staging: android: fix style problem

On Sat, Jun 15, 2019 at 01:11:56AM +0530, Saiyam Doshi wrote:
> checkpatch reported "WARNING: line over 80 characters". This
> patch fixes it by aligning function arguments.
> 
> Signed-off-by: Saiyam Doshi <saiyamdoshi.in@...il.com>
> ---
>  drivers/staging/android/ion/ion_chunk_heap.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/android/ion/ion_chunk_heap.c b/drivers/staging/android/ion/ion_chunk_heap.c
> index 3cdde9c1a717..6aceab2e77e4 100644
> --- a/drivers/staging/android/ion/ion_chunk_heap.c
> +++ b/drivers/staging/android/ion/ion_chunk_heap.c
> @@ -107,7 +107,9 @@ static struct ion_heap_ops chunk_heap_ops = {
>  	.unmap_kernel = ion_heap_unmap_kernel,
>  };
>  
> -struct ion_heap *ion_chunk_heap_create(phys_addr_t base, size_t size, size_t chunk_size)
> +struct ion_heap *ion_chunk_heap_create(phys_addr_t base,
> +				       size_t size,
> +				       size_t chunk_size)

Just break the line at "size_t size,", no need for 3 lines when 2 will
do.

thanks,

greg k-h