Date:   Sat, 15 Jun 2019 11:24:44 -0700
From:   Tejun Heo <tj@...nel.org>
To:     dsterba@...e.com, clm@...com, josef@...icpanda.com,
        axboe@...nel.dk, jack@...e.cz
Cc:     linux-btrfs@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-block@...r.kernel.org, kernel-team@...com
Subject: [PATCHSET v2 btrfs/for-next] blkcg, btrfs: fix cgroup writeback support

Hello,

Changes from v1[1]

  * 0001-cgroup-blkcg-Prepare-some-symbols-for-module-and-CON.patch
    added.  It collects and adds symbol exports and dummy function def
    to fix module and different config builds.

When writeback is executed asynchronously (e.g. for compression), bios
are bounced to and issued by worker pool shared by all cgroups.  This
leads to significant priority inversions when cgroup IO control is in
use - IOs for a low priority cgroup can tie down the workers forcing
higher priority IOs to wait behind them.

This patchset adds an bio punt mechanism to blkcg and updates btrfs to
issue async IOs through it.  A bio tagged with REQ_CGROUP_PUNT flag is
bounced to the asynchronous issue context of the associated blkcg on
bio_submit().  As the bios are issued from per-blkcg work items,
there's no concern for priority inversions and it doesn't require
invasive changes to the filesystems.  The mechanism should be
generally useful for IO control support across different filesystems.

This patchset contains the following 9 patches.  The first three are
my blkcg patches to implement the needed mechanisms.  The latter five
are Chris Mason's btrfs cleanup and update patches.  Please let me
know how the patches should be routed.  Given that there currently
aren't other users, it's likely the easiest to route all through btrfs
tree.

 0001-cgroup-blkcg-Prepare-some-symbols-for-module-and-CON.patch
 0002-blkcg-writeback-Add-wbc-no_wbc_acct.patch
 0003-blkcg-writeback-Implement-wbc_blkcg_css.patch
 0004-blkcg-implement-REQ_CGROUP_PUNT.patch
 0005-Btrfs-stop-using-btrfs_schedule_bio.patch
 0006-Btrfs-delete-the-entire-async-bio-submission-framewo.patch
 0007-Btrfs-only-associate-the-locked-page-with-one-async_.patch
 0008-Btrfs-use-REQ_CGROUP_PUNT-for-worker-thread-submitte.patch
 0009-Btrfs-extent_write_locked_range-should-attach-inode-.patch

0001-0003 implement wbc->no_wbc_acct, wbc_blkcg_css() and
REQ_CGROUP_PUNT.

0004-0007 are prep patches to simplify / improve async bio submission.

0008 makes btrfs use REQ_CGROUP_PUNT for async bios.

0009 fixes wbc writeback accounting for IOs issued through
extent_write_locked_range().

This patchset is also available in the following git branch.

 git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git review-btrfs-cgroup-updates-v2

Thanks, diffstat follows.

 block/blk-cgroup.c          |   54 +++++++++
 block/blk-core.c            |    3 
 fs/btrfs/compression.c      |   16 +-
 fs/btrfs/compression.h      |    3 
 fs/btrfs/ctree.h            |    1 
 fs/btrfs/disk-io.c          |   25 +---
 fs/btrfs/extent_io.c        |   15 +-
 fs/btrfs/inode.c            |   61 ++++++++--
 fs/btrfs/super.c            |    1 
 fs/btrfs/volumes.c          |  264 --------------------------------------------
 fs/btrfs/volumes.h          |   10 -
 fs/fs-writeback.c           |    5 
 include/linux/backing-dev.h |    1 
 include/linux/blk-cgroup.h  |   16 ++
 include/linux/blk_types.h   |   10 +
 include/linux/cgroup.h      |    1 
 include/linux/writeback.h   |   24 +++-
 17 files changed, 198 insertions(+), 312 deletions(-)

--
tejun

[1] http://lkml.kernel.org/r/20190614003350.1178444-1-tj@kernel.org

Powered by blists - more mailing lists