linux-kernel - Re: [PATCH 4.19 070/118] iommu/arm-smmu-v3: Dont disable SMMU in kdump kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190616194236.GB6676@amd>
Date:   Sun, 16 Jun 2019 21:42:36 +0200
From:   Pavel Machek <pavel@...x.de>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        "Leizhen (ThunderTown)" <thunder.leizhen@...wei.com>,
        Bhupesh Sharma <bhsharma@...hat.com>,
        Will Deacon <will.deacon@....com>,
        Sasha Levin <sashal@...nel.org>
Subject: Re: [PATCH 4.19 070/118] iommu/arm-smmu-v3: Dont disable SMMU in
 kdump kernel

Hi!

> [ Upstream commit 3f54c447df34ff9efac7809a4a80fd3208efc619 ]
> 
> Disabling the SMMU when probing from within a kdump kernel so that all
> incoming transactions are terminated can prevent the core of the crashed
> kernel from being transferred off the machine if all I/O devices are
> behind the SMMU.
> 
> Instead, continue to probe the SMMU after it is disabled so that we can
> reinitialise it entirely and re-attach the DMA masters as they are reset.
> Since the kdump kernel may not have drivers for all of the active DMA
> masters, we suppress fault reporting to avoid spamming the console and
> swamping the IRQ threads.

> +++ b/drivers/iommu/arm-smmu-v3.c
> @@ -2414,13 +2414,9 @@ static int arm_smmu_device_reset(struct arm_smmu_device *smmu, bool bypass)
>  	/* Clear CR0 and sync (disables SMMU and queue processing) */
>  	reg = readl_relaxed(smmu->base + ARM_SMMU_CR0);
>  	if (reg & CR0_SMMUEN) {
> -		if (is_kdump_kernel()) {
> -			arm_smmu_update_gbpa(smmu, GBPA_ABORT, 0);
> -			arm_smmu_device_disable(smmu);
> -			return -EBUSY;
> -		}
> -
>  		dev_warn(smmu->dev, "SMMU currently enabled! Resetting...\n");
> +		WARN_ON(is_kdump_kernel() && !disable_bypass);
> +		arm_smmu_update_gbpa(smmu, GBPA_ABORT, 0);
>  	}
>

This changes behaviour in !is_kdump_kernel() case. Is that
ok/intended?

Best regards,
     								Pavel
								
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)