linux-kernel - Re: [PATCH 4.19 117/118] ovl: support stacked SEEK_HOLE/SEEK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 16 Jun 2019 21:59:19 +0200
From:   Pavel Machek <pavel@....cz>
To:     pavel@....cz
Cc:     linux-kernel@...r.kernel.org,
        Eddie Horng <eddiehorng.tw@...il.com>,
        Amir Goldstein <amir73il@...il.com>,
        Miklos Szeredi <mszeredi@...hat.com>
Subject: Re: [PATCH 4.19 117/118] ovl: support stacked SEEK_HOLE/SEEK_DATA

Hi!

> ---
>  fs/overlayfs/file.c |   44 ++++++++++++++++++++++++++++++++++++++++----
>  1 file changed, 40 insertions(+), 4 deletions(-)
> 
> --- a/fs/overlayfs/file.c
> +++ b/fs/overlayfs/file.c
> @@ -146,11 +146,47 @@ static int ovl_release(struct inode *ino
>  
>  static loff_t ovl_llseek(struct file *file, loff_t offset, int whence)
>  {
> -	struct inode *realinode = ovl_inode_real(file_inode(file));
> +	struct inode *inode = file_inode(file);
> +	struct fd real;
> +	const struct cred *old_cred;
> +	ssize_t ret;
>  
> -	return generic_file_llseek_size(file, offset, whence,
> -					realinode->i_sb->s_maxbytes,
> -					i_size_read(realinode));
> +	/*
> +	 * The two special cases below do not need to involve real fs,
> +	 * so we can optimizing concurrent callers.
> +	 */

AFAICT correct english is "optimize".

Thanks,
								Pavel
								
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)