linux-kernel - Re: [PATCH net-next] net: ethernet: ti: davinci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190616.140341.1206535816113380121.davem@davemloft.net>
Date:   Sun, 16 Jun 2019 14:03:41 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     ivan.khoronzhuk@...aro.org
Cc:     grygorii.strashko@...com, linux-omap@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: ethernet: ti: davinci_cpdma: use idled
 submit

From: Ivan Khoronzhuk <ivan.khoronzhuk@...aro.org>
Date: Sat, 15 Jun 2019 14:01:32 +0300

> While data pass suspend, reuse of rx descriptors can be disabled using
> channel state & lock from cpdma layer. For this, submit to a channel
> has to be disabled using state != "not active" under lock, what is done
> with this patch. The same submit is used to fill rx channel while
> ndo_open, when channel is idled, so add idled submit routine that
> allows to prepare descs for the channel. All this simplifies code and
> helps to avoid dormant mode usage and send packets only to active
> channels, avoiding potential race in later on changes. Also add missed
> sync barrier analogically like in other places after stopping tx
> queues.
> 
> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@...aro.org>

Applied.