linux-kernel - Re: [PATCH] firmware: improve LSM/IMA security behaviour

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1560796442.4072.170.camel@linux.ibm.com>
Date:   Mon, 17 Jun 2019 14:34:02 -0400
From:   Mimi Zohar <zohar@...ux.ibm.com>
To:     Sven Van Asbroeck <thesven73@...il.com>,
        Luis Chamberlain <mcgrof@...nel.org>
Cc:     Stable <stable@...r.kernel.org>,
        Mimi Zohar <zohar@...ux.vnet.ibm.com>,
        Kees Cook <keescook@...omium.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] firmware: improve LSM/IMA security behaviour

On Mon, 2019-06-17 at 14:23 -0400, Sven Van Asbroeck wrote:
> The firmware loader queries if LSM/IMA permits it to load firmware
> via the sysfs fallback. Unfortunately, the code does the opposite:
> it expressly permits sysfs fw loading if security_kernel_load_data(
> LOADING_FIRMWARE) returns -EACCES. This happens because a
> zero-on-success return value is cast to a bool that's true on success.
> 
> Fix the return value handling so we get the correct behaviour.

Reviewed-by: Mimi Zohar <zohar@...ux.ibm.com>