linux-kernel - Re: [PATCH 3/4] regulator: Add regulator driver for ATC260x PMICs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190617203008.GB8381@kroah.com>
Date:   Mon, 17 Jun 2019 22:30:08 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Andreas Färber <afaerber@...e.de>
Cc:     Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
        Mark Brown <broonie@...nel.org>, lee.jones@...aro.org,
        lgirdwood@...il.com, robh+dt@...nel.org,
        linux-actions@...ts.infradead.org, linux-kernel@...r.kernel.org,
        thomas.liau@...ions-semi.com, devicetree@...r.kernel.org,
        linus.walleij@...aro.org
Subject: Re: [PATCH 3/4] regulator: Add regulator driver for ATC260x PMICs

On Mon, Jun 17, 2019 at 06:38:53PM +0200, Andreas Färber wrote:
> Hi,
> 
> Am 17.06.19 um 18:34 schrieb Manivannan Sadhasivam:
> > On Mon, Jun 17, 2019 at 05:30:15PM +0100, Mark Brown wrote:
> >> On Mon, Jun 17, 2019 at 09:20:10PM +0530, Manivannan Sadhasivam wrote:
> >>
> >>> +++ b/drivers/regulator/atc260x-regulator.c
> >>> @@ -0,0 +1,389 @@
> >>> +// SPDX-License-Identifier: GPL-2.0+
> >>> +/*
> >>> + * Regulator driver for ATC260x PMICs
> >>
> >> Please make the entire comment a C++ one so this looks more intentional.
> 
> No, this is intentional and the official style requested by GregKH.

Mark likes them all to be // at the top of the file.

I only required that the SPDX line be that way.

Mark can ask for more if he wants to :)

thanks,

greg k-h