linux-kernel - RE: [PATCH v2 1/3] ACPI: Resolve objects on host-directed table loads

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <94F2FBAB4432B54E8AACC7DFDE6C92E3B95F9EC6@ORSMSX110.amr.corp.intel.com>
Date:   Mon, 17 Jun 2019 21:18:53 +0000
From:   "Moore, Robert" <robert.moore@...el.com>
To:     Nikolaus Voss <nv@...n.de>
CC:     "Rafael J. Wysocki" <rafael@...nel.org>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Len Brown <lenb@...nel.org>,
        "Schmauss, Erik" <erik.schmauss@...el.com>,
        Jacek Anaszewski <jacek.anaszewski@...il.com>,
        Pavel Machek <pavel@....cz>, Dan Murphy <dmurphy@...com>,
        Thierry Reding <thierry.reding@...il.com>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        "open list:ACPI COMPONENT ARCHITECTURE (ACPICA)" <devel@...ica.org>,
        "linux-leds@...r.kernel.org" <linux-leds@...r.kernel.org>,
        Linux PWM List <linux-pwm@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "nikolaus.voss@...wensteinmedical.de" 
        <nikolaus.voss@...wensteinmedical.de>
Subject: RE: [PATCH v2 1/3] ACPI: Resolve objects on host-directed table
 loads



> -----Original Message-----
> From: Nikolaus Voss [mailto:nv@...n.de]
> Sent: Sunday, June 16, 2019 11:24 PM
> To: Moore, Robert <robert.moore@...el.com>
> Cc: Rafael J. Wysocki <rafael@...nel.org>; Rafael J. Wysocki
> <rjw@...ysocki.net>; Len Brown <lenb@...nel.org>; Schmauss, Erik
> <erik.schmauss@...el.com>; Jacek Anaszewski
> <jacek.anaszewski@...il.com>; Pavel Machek <pavel@....cz>; Dan Murphy
> <dmurphy@...com>; Thierry Reding <thierry.reding@...il.com>; ACPI Devel
> Maling List <linux-acpi@...r.kernel.org>; open list:ACPI COMPONENT
> ARCHITECTURE (ACPICA) <devel@...ica.org>; linux-leds@...r.kernel.org;
> Linux PWM List <linux-pwm@...r.kernel.org>; Linux Kernel Mailing List
> <linux-kernel@...r.kernel.org>; nikolaus.voss@...wensteinmedical.de
> Subject: RE: [PATCH v2 1/3] ACPI: Resolve objects on host-directed table
> loads
> 
> Bob,
> 
> On Fri, 14 Jun 2019, Moore, Robert wrote:
> >
> >
> > -----Original Message-----
> > From: Nikolaus Voss [mailto:nv@...n.de]
> > Sent: Friday, June 14, 2019 2:26 AM
> > To: Rafael J. Wysocki <rafael@...nel.org>
> > Cc: Rafael J. Wysocki <rjw@...ysocki.net>; Len Brown
> > <lenb@...nel.org>; Moore, Robert <robert.moore@...el.com>; Schmauss,
> > Erik <erik.schmauss@...el.com>; Jacek Anaszewski
> > <jacek.anaszewski@...il.com>; Pavel Machek <pavel@....cz>; Dan Murphy
> > <dmurphy@...com>; Thierry Reding <thierry.reding@...il.com>; ACPI
> > Devel Maling List <linux-acpi@...r.kernel.org>; open list:ACPI
> > COMPONENT ARCHITECTURE (ACPICA) <devel@...ica.org>;
> > linux-leds@...r.kernel.org; Linux PWM List
> > <linux-pwm@...r.kernel.org>; Linux Kernel Mailing List
> > <linux-kernel@...r.kernel.org>
> > Subject: Re: [PATCH v2 1/3] ACPI: Resolve objects on host-directed
> > table loads
> >
> > Hi Rafael,
> >
> > On Fri, 14 Jun 2019, Rafael J. Wysocki wrote:
> >> On Wed, Jun 12, 2019 at 10:36 AM Nikolaus Voss
> >> <nikolaus.voss@...wensteinmedical.de> wrote:
> >>>
> >>> If an ACPI SSDT overlay is loaded after built-in tables have been
> >>> loaded e.g. via configfs or efivar_ssdt_load() it is necessary to
> >>> rewalk the namespace to resolve references. Without this, relative
> >>> and absolute paths like ^PCI0.SBUS or \_SB.PCI0.SBUS are not
> >>> resolved correctly.
> >>>
> >>> Make configfs load use the same method as efivar_ssdt_load().
> >>>
> >>> Signed-off-by: Nikolaus Voss <nikolaus.voss@...wensteinmedical.de>
> >>
> >> This is fine by me, so
> >>
> >> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> >>
> >> Or if you want me to take this patch (without the other two in the
> >> series), please let me know.
> >
> > thanks. I think it would be the best if you take up this patch as it
> > is an independent topic. In retrospect it wasn't a good idea to put it
> > into this series.
> >
> > Kind regards,
> > Niko
> >
> > I would have to ask, why is additional code needed for package
> > initialization/resolution? It already happens elsewhere in acpica. Bob
> 
> for built-in tables loaded via acpi_ex_load_table_op() everything is
> fine, because after acpi_tb_load_table() acpi_ns_walk_namespace() is
> called to resolve references.
> 
> My fix only affects tables loaded dynamically via either acpi_configfs
> driver (for debugging purposes) or efivar_ssdt_load() (to specify a
> table on the kernel's command line). They use acpi_load_table() to load
> the table from a caller-owned buffer. To resolve the references, it is
> again necessary to rewalk the namespace, which was simply missing in
> acpi_load_table().
> 
[Moore, Robert] 

Perhaps you should call AcpiInitializeObjects after the call to AcpiLoadTable, but I will check.

> Niko