linux-kernel - Re: [PATCH 2/3] tracing: Adding additional NULL checks.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190617193659.59b28700@gandalf.local.home>
Date:   Mon, 17 Jun 2019 19:36:59 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Divya Indi <divya.indi@...cle.com>
Cc:     linux-kernel@...r.kernel.org,
        Srinivas Eeda <srinivas.eeda@...cle.com>,
        Aruna Ramakrishna <aruna.ramakrishna@...cle.com>
Subject: Re: [PATCH 2/3] tracing: Adding additional NULL checks.

On Wed, 12 Jun 2019 09:34:18 -0700
Divya Indi <divya.indi@...cle.com> wrote:

> commit f45d1225adb0 ("tracing: Kernel access to Ftrace instances")
> exported certain functions providing access to Ftrace instances from
> other kernel components.

I'm fine with the patch, the above statement is hard to understand.

-- Steve

> Adding some additional NULL checks to ensure safe usage by the users.
> 
> Signed-off-by: Divya Indi <divya.indi@...cle.com>
> ---
>  kernel/trace/trace.c        | 3 +++
>  kernel/trace/trace_events.c | 2 ++
>  2 files changed, 5 insertions(+)
> 
> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> index 1c80521..a60dc13 100644
> --- a/kernel/trace/trace.c
> +++ b/kernel/trace/trace.c
> @@ -3205,6 +3205,9 @@ int trace_array_printk(struct trace_array *tr,
>  	if (!(global_trace.trace_flags & TRACE_ITER_PRINTK))
>  		return 0;
>  
> +	if (!tr)
> +		return -EINVAL;
> +
>  	va_start(ap, fmt);
>  	ret = trace_array_vprintk(tr, ip, fmt, ap);
>  	va_end(ap);
> diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
> index b6b4618..445b059 100644
> --- a/kernel/trace/trace_events.c
> +++ b/kernel/trace/trace_events.c
> @@ -800,6 +800,8 @@ int ftrace_set_clr_event(struct trace_array *tr, char *buf, int set)
>  	char *event = NULL, *sub = NULL, *match;
>  	int ret;
>  
> +	if (!tr)
> +		return -ENODEV;
>  	/*
>  	 * The buf format can be <subsystem>:<event-name>
>  	 *  *:<event-name> means any event by that name.