linux-kernel - Re: [PATCH] fsi: sbefifo: Don't fail operations when in SBE IPL state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1780173.icGFXHrAMq@townsend>
Date:   Mon, 17 Jun 2019 12:08:33 +1000
From:   Alistair Popple <alistair@...ple.id.au>
To:     openbmc@...ts.ozlabs.org
Cc:     Eddie James <eajames@...ux.ibm.com>, linux-kernel@...r.kernel.org,
        andrew@...id.au
Subject: Re: [PATCH] fsi: sbefifo: Don't fail operations when in SBE IPL state

This fixed the problem I was having trying to issue istep operations to the 
SBE.

Tested-by: Alistair Popple <alistair@...ple.id.au>

On Monday, 21 January 2019 11:15:58 AM AEST Eddie James wrote:
> SBE fifo operations should be allowed while the SBE is in any of the
> "IPL" states. Operations should succeed in this state.
> 
> Signed-off-by: Eddie James <eajames@...ux.ibm.com>
> ---
>  drivers/fsi/fsi-sbefifo.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/fsi/fsi-sbefifo.c b/drivers/fsi/fsi-sbefifo.c
> index c7d13ac..f7665b3 100644
> --- a/drivers/fsi/fsi-sbefifo.c
> +++ b/drivers/fsi/fsi-sbefifo.c
> @@ -290,11 +290,11 @@ static int sbefifo_check_sbe_state(struct sbefifo
> *sbefifo) switch ((sbm & CFAM_SBM_SBE_STATE_MASK) >>
> CFAM_SBM_SBE_STATE_SHIFT) { case SBE_STATE_UNKNOWN:
>  		return -ESHUTDOWN;
> +	case SBE_STATE_DMT:
> +		return -EBUSY;
>  	case SBE_STATE_IPLING:
>  	case SBE_STATE_ISTEP:
>  	case SBE_STATE_MPIPL:
> -	case SBE_STATE_DMT:
> -		return -EBUSY;
>  	case SBE_STATE_RUNTIME:
>  	case SBE_STATE_DUMP: /* Not sure about that one */
>  		break;