linux-kernel - Re: [PATCH v2 06/28] drivers: Add generic helper to match by of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d050ae69-52ee-b32d-2bc0-708b408f3bd4@arm.com>
Date:   Mon, 17 Jun 2019 10:59:03 +0100
From:   Suzuki K Poulose <suzuki.poulose@....com>
To:     wsa@...-dreams.de
Cc:     linux-kernel@...r.kernel.org, gregkh@...uxfoundation.org,
        rafael@...nel.org, atull@...nel.org, andrew@...n.ch,
        daniel@...ll.ch, airlied@...ux.ie, davem@...emloft.net,
        devicetree@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        f.fainelli@...il.com, frowand.list@...il.com, hkallweit1@...il.com,
        jslaby@...e.com, jonathanh@...dia.com, lee.jones@...aro.org,
        lgirdwood@...il.com, linux-fpga@...r.kernel.org,
        linux-i2c@...r.kernel.org, linux-spi@...r.kernel.org,
        maarten.lankhorst@...ux.intel.com, broonie@...nel.org,
        mathieu.poirier@...aro.org, maxime.ripard@...tlin.com,
        mdf@...nel.org, peda@...ntia.se, robh+dt@...nel.org,
        srinivas.kandagatla@...aro.org, thierry.reding@...il.com,
        thor.thayer@...ux.intel.com, ulf.hansson@...aro.org,
        joe@...ches.com
Subject: Re: [PATCH v2 06/28] drivers: Add generic helper to match by of_node

Hi

On 14/06/2019 21:31, Wolfram Sang wrote:
>> +
>> +int device_match_of_node(struct device *dev, const void *np)
>> +{
>> +	return dev->of_node == np;
>> +}
>> +EXPORT_SYMBOL_GPL(device_match_of_node);
> 
> Is it an option to 'static inline' this simple function in the header,
> saving the EXPORT?
> 

No. This is supposed to be passed on as a call back function pointer
for the APIs. Having it as a static inline, would simply replicate
the same function through the driver subsystems, which is one of the
issues that series is trying to solve. Also, by having them exported,
we can convert the new specialized device lookup functions,
*_find_device_by_<property> to be static inlines.

Suzuki