linux-kernel - Re: [PATCH 5/5] mm/hotplug: export try_online

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190617131459.GA639@infradead.org>
Date:   Mon, 17 Jun 2019 06:14:59 -0700
From:   'Christoph Hellwig' <hch@...radead.org>
To:     Alastair D'Silva <alastair@...ilva.org>
Cc:     'Christoph Hellwig' <hch@...radead.org>,
        'Peter Zijlstra' <peterz@...radead.org>,
        'Andrew Morton' <akpm@...ux-foundation.org>,
        'David Hildenbrand' <david@...hat.com>,
        'Oscar Salvador' <osalvador@...e.com>,
        'Michal Hocko' <mhocko@...e.com>,
        'Pavel Tatashin' <pasha.tatashin@...een.com>,
        'Wei Yang' <richard.weiyang@...il.com>,
        'Arun KS' <arunks@...eaurora.org>, 'Qian Cai' <cai@....pw>,
        'Thomas Gleixner' <tglx@...utronix.de>,
        'Ingo Molnar' <mingo@...nel.org>,
        'Josh Poimboeuf' <jpoimboe@...hat.com>,
        'Jiri Kosina' <jkosina@...e.cz>,
        'Mukesh Ojha' <mojha@...eaurora.org>,
        'Mike Rapoport' <rppt@...ux.vnet.ibm.com>,
        'Baoquan He' <bhe@...hat.com>,
        'Logan Gunthorpe' <logang@...tatee.com>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, linux-nvdimm@...ts.01.org
Subject: Re: [PATCH 5/5] mm/hotplug: export try_online_node

On Mon, Jun 17, 2019 at 06:00:00PM +1000, Alastair D'Silva wrote:
> > And all that should go through our pmem APIs, not not directly poke into
> mm
> > internals.  And if you still need core patches send them along with the
> actual
> > driver.
> 
> I tried that, but I was getting crashes as the NUMA data structures for that
> node were not initialised.
> 
> Calling this was required to prevent uninitialized accesses in the pmem
> library.

Please send your driver to the linux-nvdimm and linux-mm lists so that
it can be carefully reviewed.