linux-kernel - Re: [PATCH] coresight: platform: add OF/APCI dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f91b2cad-a16e-6474-59a6-82ad890a3a54@arm.com>
Date:   Mon, 17 Jun 2019 14:19:15 +0100
From:   Suzuki K Poulose <suzuki.poulose@....com>
To:     arnd@...db.de, mathieu.poirier@...aro.org,
        alexander.shishkin@...ux.intel.com
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] coresight: platform: add OF/APCI dependency

Hi Arnd,

On 17/06/2019 13:58, Arnd Bergmann wrote:
> When neither CONFIG_OF nor CONFIG_ACPI are set, we get a harmless
> build warning:
> 
> drivers/hwtracing/coresight/coresight-platform.c:26:12: error: unused function 'coresight_alloc_conns'
>        [-Werror,-Wunused-function]
> static int coresight_alloc_conns(struct device *dev,
>             ^
> drivers/hwtracing/coresight/coresight-platform.c:46:1: error: unused function 'coresight_find_device_by_fwnode'
>        [-Werror,-Wunused-function]
> coresight_find_device_by_fwnode(struct fwnode_handle *fwnode)
> 
> As the code is useless in that configuration anyway, just add
> a Kconfig dependency that only allows building when at least
> one of the two is set.
> 
> This should not hinder compile-testing, as CONFIG_OF can be
> enabled on any architecture.

Ok, that justifies why "not using ARM || ARM64" is better.


> 
> Fixes: ac0e232c12f0 ("coresight: platform: Use fwnode handle for device search")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Reviewed-by: Suzuki K Poulose <suzuki.poulose@....com>

> ---
>   drivers/hwtracing/coresight/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/hwtracing/coresight/Kconfig b/drivers/hwtracing/coresight/Kconfig
> index 5487d4a1abc2..14638db4991d 100644
> --- a/drivers/hwtracing/coresight/Kconfig
> +++ b/drivers/hwtracing/coresight/Kconfig
> @@ -4,6 +4,7 @@
>   #
>   menuconfig CORESIGHT
>   	bool "CoreSight Tracing Support"
> +	depends on OF || ACPI
>   	select ARM_AMBA
>   	select PERF_EVENTS
>   	help
>