linux-kernel - Re: [PATCH] staging: erofs: clean up initialization of pointer de

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <470b93fd-ef5e-0019-b58d-8e38e7944e13@huawei.com>
Date:   Mon, 17 Jun 2019 21:45:09 +0800
From:   Gao Xiang <gaoxiang25@...wei.com>
To:     Colin King <colin.king@...onical.com>,
        Chao Yu <yuchao0@...wei.com>,
        "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>
CC:     <linux-erofs@...ts.ozlabs.org>, <devel@...verdev.osuosl.org>,
        <kernel-janitors@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: erofs: clean up initialization of pointer de



On 2019/6/17 20:55, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Currently pointer de is being initialized with a value that is
> never read and a few statements later de is being re-assigned. Clean
> this up by ininitialzing de and removing the re-assignment.
> 
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Loods good for me,

Reviewed-by: Gao Xiang <gaoxiang25@...wei.com>

Thanks,
Gao Xiang