linux-kernel - Re: [PATCH] integrity: Fix __integrity_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1f2d599b-77dd-18eb-3e99-e93cc79cfddf@linux.vnet.ibm.com>
Date:   Mon, 17 Jun 2019 10:04:55 -0400
From:   Nayna <nayna@...ux.vnet.ibm.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Nayna Jain <nayna@...ux.ibm.com>, Mimi Zohar <zohar@...ux.ibm.com>,
        James Morris <jmorris@...ei.org>,
        "Serge E . Hallyn" <serge@...lyn.com>,
        linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] integrity: Fix __integrity_init_keyring() section
 mismatch



On 06/17/2019 03:44 AM, Geert Uytterhoeven wrote:
> With gcc-4.6.3:
>
>      WARNING: vmlinux.o(.text.unlikely+0x24c64): Section mismatch in reference from the function __integrity_init_keyring() to the function .init.text:set_platform_trusted_keys()
>      The function __integrity_init_keyring() references
>      the function __init set_platform_trusted_keys().
>      This is often because __integrity_init_keyring lacks a __init
>      annotation or the annotation of set_platform_trusted_keys is wrong.
>
> Indeed, if the compiler decides not to inline __integrity_init_keyring(),
> a warning is issued.
>
> Fix this by adding the missing __init annotation.
>
> Fixes: 9dc92c45177ab70e ("integrity: Define a trusted platform keyring")
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>

Thanks for fixing it.

Reviewed-by: Nayna Jain <nayna@...ux.ibm.com>

Thanks & Regards,
          - Nayna