linux-kernel - Re: [PATCH] proc/sysctl: make firmware loader table conditional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK8P3a3SOgF90wf_huoYV9_OR+xU=007bdVPGoo7pE6FJBvwgw@mail.gmail.com>
Date:   Mon, 17 Jun 2019 17:00:11 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Matteo Croce <mcroce@...hat.com>
Cc:     Luis Chamberlain <mcgrof@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Kees Cook <keescook@...omium.org>,
        Aaron Tomlin <atomlin@...hat.com>,
        Matthew Wilcox <willy@...radead.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] proc/sysctl: make firmware loader table conditional

On Mon, Jun 17, 2019 at 4:42 PM Matteo Croce <mcroce@...hat.com> wrote:
> >  drivers/base/firmware_loader/fallback_table.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/base/firmware_loader/fallback_table.c b/drivers/base/firmware_loader/fallback_table.c
> > index 58d4a1263480..ba9d30b28edc 100644
> > --- a/drivers/base/firmware_loader/fallback_table.c
> > +++ b/drivers/base/firmware_loader/fallback_table.c
> > @@ -23,6 +23,7 @@ struct firmware_fallback_config fw_fallback_config = {
> >  };
> >  EXPORT_SYMBOL_GPL(fw_fallback_config);
> >
> > +#ifdef CONFIG_SYSCTL
> >  struct ctl_table firmware_config_table[] = {
> >         {
> >                 .procname       = "force_sysfs_fallback",
> > @@ -45,3 +46,4 @@ struct ctl_table firmware_config_table[] = {
> >         { }
> >  };
> >  EXPORT_SYMBOL_GPL(firmware_config_table);
> > +#endif
> > --
> > 2.20.0
> >
>
> Hi Arnd,
>
> I think I've posted a similar patch before, I don't know if it's
> already in linux-next:
>
> https://lore.kernel.org/linux-next/20190531012649.31797-1-mcroce@redhat.com/
>

Indeed, that is almost the same patch. Not sure what happened.

As Stephen replied to your patch, he had picked it up originally.
Maybe it got lost in a rebase since then.

        Arnd