linux-kernel - Re: [PATCH] drm/amd/powerplay: Delete a redundant memory setting in vega20_set_default_od8_setttings()

Open Source and information security mailing list archives

Message-ID: <CADnq5_MKRU6-iCJZWwpR8z+mmdkgVh_STJtVJCiSTec21e+oqA@mail.gmail.com>
Date:   Mon, 17 Jun 2019 11:06:14 -0400
From:   Alex Deucher <alexdeucher@...il.com>
To:     Markus Elfring <Markus.Elfring@....de>
Cc:     Maling list - DRI developers <dri-devel@...ts.freedesktop.org>,
        amd-gfx list <amd-gfx@...ts.freedesktop.org>,
        Alex Deucher <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>,
        Daniel Vetter <daniel@...ll.ch>,
        David Airlie <airlied@...ux.ie>,
        "David (ChunMing) Zhou" <David1.Zhou@....com>,
        Evan Quan <evan.quan@....com>, Rex Zhu <rex.zhu@....com>,
        kernel-janitors@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/amd/powerplay: Delete a redundant memory setting in vega20_set_default_od8_setttings()

Applied this and the dc patch.

Thanks!

Alex

On Mon, Jun 17, 2019 at 10:07 AM Markus Elfring <Markus.Elfring@....de> wrote:
>
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Mon, 17 Jun 2019 14:24:14 +0200
>
> The memory was set to zero already by a call of the function “kzalloc”.
> Thus remove an extra call of the function “memset” for this purpose.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> ---
>  drivers/gpu/drm/amd/powerplay/vega20_ppt.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/vega20_ppt.c b/drivers/gpu/drm/amd/powerplay/vega20_ppt.c
> index 4aa8f5a69c4c..62497ad66a39 100644
> --- a/drivers/gpu/drm/amd/powerplay/vega20_ppt.c
> +++ b/drivers/gpu/drm/amd/powerplay/vega20_ppt.c
> @@ -1295,7 +1295,6 @@ static int vega20_set_default_od8_setttings(struct smu_context *smu)
>         if (!table_context->od8_settings)
>                 return -ENOMEM;
>
> -       memset(table_context->od8_settings, 0, sizeof(struct vega20_od8_settings));
>         od8_settings = (struct vega20_od8_settings *)table_context->od8_settings;
>
>         if (smu_feature_is_enabled(smu, FEATURE_DPM_SOCCLK_BIT)) {
> --
> 2.22.0
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives