linux-kernel - Re: [PATCH next v2] of/fdt: Fix defined but not used compiler warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5d07ad51.1c69fb81.25c8.f3a0@mx.google.com>
Date:   Mon, 17 Jun 2019 08:10:08 -0700
From:   Stephen Boyd <swboyd@...omium.org>
To:     Kefeng Wang <wangkefeng.wang@...wei.com>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     Kefeng Wang <wangkefeng.wang@...wei.com>,
        Rob Herring <robh@...nel.org>,
        Frank Rowand <frowand.list@...il.com>,
        Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH next v2] of/fdt: Fix defined but not used compiler warning

Quoting Kefeng Wang (2019-06-14 20:03:43)
> When CONFIG_OF_EARLY_FLATTREE is disabled, there is a compiler
> warning,
> 
> drivers/of/fdt.c:129:19: warning: ‘of_fdt_match’ defined but not used [-Wunused-function]
>  static int __init of_fdt_match(const void *blob, unsigned long node,
> 
> Since the only caller of of_fdt_match() is of_flat_dt_match(),
> let's move the body of of_fdt_match() into of_flat_dt_match()
> and eliminate of_fdt_match().
> 
> Meanwhile, move of_fdt_is_compatible() under CONFIG_OF_EARLY_FLATTREE,
> as all callers are over there.
> 
> Cc: Stephen Boyd <swboyd@...omium.org>
> Cc: Rob Herring <robh@...nel.org>
> Cc: Frank Rowand <frowand.list@...il.com>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@...wei.com>
> ---

Reviewed-by: Stephen Boyd <swboyd@...omium.org>

Arnd sent something similar now too.