linux-kernel - Re: [PATCH v2 02/11] ALSA: hdac: Fix codec name after machine driver is unloaded and reloaded

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5h4l4ofcx8.wl-tiwai@suse.de>
Date:   Mon, 17 Jun 2019 17:29:23 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Amadeusz Sławiński 
        <amadeuszx.slawinski@...ux.intel.com>
Cc:     <alsa-devel@...a-project.org>,
        "Liam Girdwood" <lgirdwood@...il.com>,
        "Cezary Rojewski" <cezary.rojewski@...el.com>,
        "Mark Brown" <broonie@...nel.org>,
        "Pierre-Louis Bossart" <pierre-louis.bossart@...ux.intel.com>,
        "Jie Yang" <yang.jie@...ux.intel.com>,
        "Jaroslav Kysela" <perex@...ex.cz>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 02/11] ALSA: hdac: Fix codec name after machine driver is unloaded and reloaded

On Mon, 17 Jun 2019 13:36:35 +0200,
Amadeusz Sławiński wrote:
> 
> Currently on each driver reload internal counter is being increased. It
> causes failure to enumerate driver devices, as they have hardcoded:
> .codec_name = "ehdaudio0D2",
> As there is currently no devices with multiple hda codecs and there is
> currently no established way to reliably differentiate, between them,
> always assign bus->idx = 0;
> 
> This fixes a problem when we unload and reload machine driver idx gets
> incremented, so .codec_name would've needed to be set to "ehdaudio1D2"
> after first reload and so on.
> 
> Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@...ux.intel.com>

Acked-by: Takashi Iwai <tiwai@...e.de>


Takashi