linux-kernel - Re: [PATCH] Use fall-through attribute rather than magic comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190617155643.GA32544@amd>
Date:   Mon, 17 Jun 2019 17:56:43 +0200
From:   Pavel Machek <pavel@....cz>
To:     Shawn Landden <shawn@....icu>
Cc:     linux-kernel@...r.kernel.org,
        "Gustavo A . R . Silva" <gustavo@...eddedor.com>,
        Joe Perches <joe@...ches.com>,
        Andy Whitcroft <apw@...onical.com>
Subject: Re: [PATCH] Use fall-through attribute rather than magic comments

Hi!

> +/*
> + *   gcc: https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wimplicit-fallthrough
> + *   gcc: https://developers.redhat.com/blog/2017/03/10/wimplicit-fallthrough-in-gcc-7/
> + */
> +#if __has_attribute(__fallthrough__)
> +# define __fallthrough                    __attribute__((__fallthrough__))
> +#else
> +# define __fallthrough
> +#endif

Is it good idea to add the __'s ? They look kind of ugly. 
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)