linux-kernel - Re: [PATCH] fib_semantics: Fix warning in fib_check_nh_v4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <33c98309-a8d2-ecfe-7385-72769a571d9b@gmail.com>
Date:   Mon, 17 Jun 2019 11:12:10 -0600
From:   David Ahern <dsahern@...il.com>
To:     Vincenzo Frascino <vincenzo.frascino@....com>,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Cc:     davem@...emloft.net, kuznet@....inr.ac.ru, yoshfuji@...ux-ipv6.org
Subject: Re: [PATCH] fib_semantics: Fix warning in fib_check_nh_v4_gw

On 6/17/19 4:21 AM, Vincenzo Frascino wrote:
> Currently, the err variable in fib_check_nh_v4_gw may be used
> uninitialized leading to the warning below:
> 
>   fib_semantics.c: In function ‘fib_check_nh_v4_gw’:
>   fib_semantics.c:1023:12: warning: ‘err’ may be used
>     uninitialised in this function [-Wmaybe-uninitialized]
>        if (!tbl || err) {
>                    ^~
> 
> Initialize err to 0 to fix the warning.
> 
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Alexey Kuznetsov <kuznet@....inr.ac.ru>
> Cc: Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>
> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@....com>
> ---
>  net/ipv4/fib_semantics.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

already fixed in net; will make it to net-next on next merge.