linux-kernel - Re: [PATCH RFC 2/3] fonts: Use BUILD_BUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <896583b9-3231-9e31-e51b-c76b889db85b@infradead.org>
Date:   Tue, 18 Jun 2019 16:05:58 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Takashi Iwai <tiwai@...e.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH RFC 2/3] fonts: Use BUILD_BUG_ON() for checking empty font
 table

On 6/18/19 1:34 PM, Takashi Iwai wrote:
> We have a nice macro, and the check of emptiness of the font table can
> be done in a simpler way.
> 
> Signed-off-by: Takashi Iwai <tiwai@...e.de>

Hi,

Looks good to me.
Acked-by: Randy Dunlap <rdunlap@...radead.org>

Also, would you mind adding TER16x32 to Documentation/fb/fbcon.rst, here:
(AFAIK that would be appropriate.)

1. fbcon=font:<name>

	Select the initial font to use. The value 'name' can be any of the
	compiled-in fonts: 10x18, 6x10, 7x14, Acorn8x8, MINI4x6,
	PEARL8x8, ProFont6x11, SUN12x22, SUN8x16, VGA8x16, VGA8x8.

> ---
>  lib/fonts/fonts.c | 15 +--------------
>  1 file changed, 1 insertion(+), 14 deletions(-)

Thanks.
-- 
~Randy