linux-kernel - Re: [PATCH 1/2] include: linux: siox: more for declaring siox drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 18 Jun 2019 07:54:30 +0200
From:   Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>
To:     "Enrico Weigelt, metux IT consult" <info@...ux.net>
Cc:     linux-kernel@...r.kernel.org, bgolaszewski@...libre.com,
        linus.walleij@...aro.org, kernel@...gutronix.de,
        linux-gpio@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Thorsten Scherer <t.scherer@...elmann.de>
Subject: Re: [PATCH 1/2] include: linux: siox: more for declaring siox drivers

On Mon, Jun 17, 2019 at 08:21:27PM +0200, Enrico Weigelt, metux IT consult wrote:
> From: Enrico Weigelt <info@...ux.net>
> 
> Add more helper macros for trivial driver init cases, similar to the
> already existing module_platform_driver or module_i2c_driver().

Inconsistent use of () after macro names.

Other than that (and my remark for patch 2) I'm ok with this series.
Usually Greg (on Cc:) merges siox stuff, but I don't expect anything to
happen which conflicts with this series so I think it's fine if both
patches go in via the gpio tree.

> +
> +/* module_siox_driver() - Helper macro for drivers that don't do
> + * anything special in module init/exit.  This eliminates a lot of
> + * boilerplate.  Each module may only use this macro once, and

Given there is only one siox driver in the tree, "a lot" seems bold, but
I don't mind it.

> + * calling it replaces module_init() and module_exit()
> + */
> +#define module_siox_driver(__siox_driver) \
> +	module_driver(__siox_driver, siox_driver_register, \
> +			siox_driver_unregister)

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |