linux-kernel - Re: [PATCH RESEND] fs: cramfs_fs.h: Fix shifting signed 32-bit value by 31 bits problem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190618065920.GA3620@infradead.org>
Date:   Mon, 17 Jun 2019 23:59:20 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Puranjay Mohan <puranjay12@...il.com>
Cc:     Shuah Khan <skhan@...uxfoundation.org>,
        linux-kernel-mentees@...ts.linuxfoundation.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND] fs: cramfs_fs.h: Fix shifting signed 32-bit value
 by 31 bits problem

> -#define CRAMFS_BLK_FLAG_UNCOMPRESSED	(1 << 31)
> +#define CRAMFS_BLK_FLAG_UNCOMPRESSED	(1U << 31)
>  #define CRAMFS_BLK_FLAG_DIRECT_PTR	(1 << 30)

Please use the unsigned constants for all flags, not just one.