linux-kernel - Re: [PATCH] tty: serial_core: recover uport->cons->cflag on uart

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190618075129.GA5758@kroah.com>
Date:   Tue, 18 Jun 2019 09:51:29 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     kpark3469@...il.com
Cc:     jslaby@...e.com, linux-serial@...r.kernel.org,
        linux-kernel@...r.kernel.org, keun-o.park@...kmatter.ae
Subject: Re: [PATCH] tty: serial_core: recover uport->cons->cflag on
 uart_close

On Sun, Jun 16, 2019 at 06:57:14PM +0400, kpark3469@...il.com wrote:
> From: Sahara <keun-o.park@...kmatter.ae>

I need a "full" name here please, something you use to sign legal
documents.

> Since uart_close was converted to use tty_port_close, uart_shutdown
> also moved to uart_tty_port_shutdown, which means it does not backup
> tty's termios to uart_port.console.cflag when console is closed and
> uart_console is true.
> By losing this value, serial console was not set correctly especially
> after suspend/resume when there is no consumer of console device.
> This problem resets console driver's configuration to an unwanted value
> and may give a performance regression in the system eventually.
> This patch fixes the bug introduced from v4.9 kernel.
> 
> Fixes: 761ed4a94582 ("tty: serial_core: convert uart_close to use tty_port_close")
> Reported-by: Jouni Linnamaa <Jouni.Linnamaa@...kmatter.ae>
> Signed-off-by: Sahara <keun-o.park@...kmatter.ae>

Same here as well.

thanks,

greg k-h