linux-kernel - Re: [PATCH V1] i2c: tegra: disable irq in tegra_i2c_xfer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <93b72301-2132-f9da-b5b8-f2fb3c4163c4@nvidia.com>
Date:   Tue, 18 Jun 2019 01:53:21 -0700
From:   Bitan Biswas <bbiswas@...dia.com>
To:     Jon Hunter <jonathanh@...dia.com>,
        Laxman Dewangan <ldewangan@...dia.com>,
        Thierry Reding <treding@...dia.com>,
        <linux-i2c@...r.kernel.org>, <linux-tegra@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, Peter Rosin <peda@...ntia.se>,
        Wolfram Sang <wsa@...-dreams.de>,
        Dmitry Osipenko <digetx@...il.com>
CC:     Shardar Mohammed <smohammed@...dia.com>,
        Sowjanya Komatineni <skomatineni@...dia.com>,
        Mantravadi Karthik <mkarthik@...dia.com>
Subject: Re: [PATCH V1] i2c: tegra: disable irq in tegra_i2c_xfer_msg



On 6/17/19 11:32 PM, Jon Hunter wrote:
> 
> On 18/06/2019 06:23, Bitan Biswas wrote:
>> Synchronize ISR and tegra_i2c_xfer_msg execution
>> by disabling interrupt. This avoids spinlock usage
>> for same purpose.
> 
> I think that you need to explain the motivation/benefit of this. It is
> not immediately clear to me. Sorry if I have missed some previous
> discussion.
I updated the commit description with details and benefit. Please review 
Patch V2.

-regards,
  Bitan