linux-kernel - Re: [PATCH 3/8] sched,fair: redefine runnable_load_avg as the sum of task_h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 18 Jun 2019 11:08:09 +0200
From:   Dietmar Eggemann <dietmar.eggemann@....com>
To:     Rik van Riel <riel@...riel.com>, peterz@...radead.org
Cc:     mingo@...hat.com, linux-kernel@...r.kernel.org, kernel-team@...com,
        morten.rasmussen@....com, tglx@...utronix.de,
        dietmar.eggeman@....com, mgorman@...hsingularity.com,
        vincent.guittot@...aro.org
Subject: Re: [PATCH 3/8] sched,fair: redefine runnable_load_avg as the sum of
 task_h_load

Hi Rik,

On 6/12/19 9:32 PM, Rik van Riel wrote:

[...]

> @@ -379,17 +368,11 @@ int update_irq_load_avg(struct rq *rq, u64 running)
>   	 * We can safely remove running from rq->clock because
>   	 * rq->clock += delta with delta >= running
>   	 */
> -	ret = ___update_load_sum(rq->clock - running, &rq->avg_irq,
> -				0,
> -				0,
> -				0);
> -	ret += ___update_load_sum(rq->clock, &rq->avg_irq,
> -				1,
> -				1,
> -				1);
> +	ret = ___update_load_sum(rq->clock - running, &rq->avg_irq, 0);
> +	ret += ___update_load_sum(rq->clock, &rq->avg_irq, 1);

The 'int running' argument in the two ___update_load_sum() calls is 
missing. Doesn't compile for me (arm64 defconfig w/ 
CONFIG_IRQ_TIME_ACCOUNTING=y).

[...]