linux-kernel - Re: [PATCH V2 2/2] soc: imx8: Use existing of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190618091442.GM29881@dragon>
Date:   Tue, 18 Jun 2019 17:14:45 +0800
From:   Shawn Guo <shawnguo@...nel.org>
To:     Anson.Huang@....com
Cc:     s.hauer@...gutronix.de, kernel@...gutronix.de, festevam@...il.com,
        leonard.crestez@....com, viresh.kumar@...aro.org,
        abel.vesa@....com, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, Linux-imx@....com
Subject: Re: [PATCH V2 2/2] soc: imx8: Use existing of_root directly

On Fri, Jun 14, 2019 at 04:07:48PM +0800, Anson.Huang@....com wrote:
> From: Anson Huang <Anson.Huang@....com>
> 
> There is common of_root for reference, no need to find it
> from DT again, use of_root directly to make driver simple.
> 
> Signed-off-by: Anson Huang <Anson.Huang@....com>
> Reviewed-by: Dong Aisheng <aisheng.dong@....com>

It cannot be applied.  Please resend by basing on my imx/drivers branch.

Shawn

> ---
> No changes.
> ---
>  drivers/soc/imx/soc-imx8.c | 9 ++-------
>  1 file changed, 2 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/soc/imx/soc-imx8.c b/drivers/soc/imx/soc-imx8.c
> index 5c7f330..b459bf2 100644
> --- a/drivers/soc/imx/soc-imx8.c
> +++ b/drivers/soc/imx/soc-imx8.c
> @@ -105,7 +105,6 @@ static int __init imx8_soc_init(void)
>  {
>  	struct soc_device_attribute *soc_dev_attr;
>  	struct soc_device *soc_dev;
> -	struct device_node *root;
>  	const struct of_device_id *id;
>  	u32 soc_rev = 0;
>  	const struct imx8_soc_data *data;
> @@ -117,12 +116,11 @@ static int __init imx8_soc_init(void)
>  
>  	soc_dev_attr->family = "Freescale i.MX";
>  
> -	root = of_find_node_by_path("/");
> -	ret = of_property_read_string(root, "model", &soc_dev_attr->machine);
> +	ret = of_property_read_string(of_root, "model", &soc_dev_attr->machine);
>  	if (ret)
>  		goto free_soc;
>  
> -	id = of_match_node(imx8_soc_match, root);
> +	id = of_match_node(imx8_soc_match, of_root);
>  	if (!id) {
>  		ret = -ENODEV;
>  		goto free_soc;
> @@ -147,8 +145,6 @@ static int __init imx8_soc_init(void)
>  		goto free_rev;
>  	}
>  
> -	of_node_put(root);
> -
>  	if (IS_ENABLED(CONFIG_ARM_IMX_CPUFREQ_DT))
>  		platform_device_register_simple("imx-cpufreq-dt", -1, NULL, 0);
>  
> @@ -159,7 +155,6 @@ static int __init imx8_soc_init(void)
>  		kfree(soc_dev_attr->revision);
>  free_soc:
>  	kfree(soc_dev_attr);
> -	of_node_put(root);
>  	return ret;
>  }
>  device_initcall(imx8_soc_init);
> -- 
> 2.7.4
>