linux-kernel - Re: [PATCH] soc: ixp4xx: npe: Fix an IS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdaX66=g7dG7SFkgr5Dwmop-p4qe7ELkn0KERtqVvp0vNA@mail.gmail.com>
Date:   Tue, 18 Jun 2019 13:35:19 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Krzysztof Halasa <khalasa@...p.pl>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org, Olof Johansson <olof@...om.net>
Subject: Re: [PATCH] soc: ixp4xx: npe: Fix an IS_ERR() vs NULL check in probe

On Thu, Jun 13, 2019 at 9:02 AM Dan Carpenter <dan.carpenter@...cle.com> wrote:

> The devm_ioremap_resource() function doesn't return NULL, it returns
> error pointers.
>
> Fixes: 0b458d7b10f8 ("soc: ixp4xx: npe: Pass addresses as resources")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Can you please collect my review and send this to the ARM SoC maintainers
arm@...nel.org since they are collecting a few other IXP4xx fixes?

Yours,
Linus Walleij