linux-kernel - Re: [PATCH] Arm: zx: remove redundant dev_err message

Open Source and information security mailing list archives

Message-ID: <20190618134634.GL1959@dragon>
Date:   Tue, 18 Jun 2019 21:46:36 +0800
From:   Shawn Guo <shawnguo@...nel.org>
To:     Ding Xiang <dingxiang@...s.chinamobile.com>,
        Arnd Bergmann <arnd@...db.de>, Olof Johansson <olof@...om.net>
Cc:     jun.nie@...aro.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] Arm: zx: remove redundant dev_err message

On Tue, Jun 18, 2019 at 03:39:01PM +0800, Ding Xiang wrote:
> devm_ioremap_resource already contains error message, so remove
> the redundant dev_err message
> 
> Signed-off-by: Ding Xiang <dingxiang@...s.chinamobile.com>

Acked-by: Shawn Guo <shawnguo@...nel.org>

Arnd, Olof,

Can you please apply it to arm-soc tree?  Thanks.

Shawn

> ---
>  arch/arm/mach-zx/zx296702-pm-domain.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/arch/arm/mach-zx/zx296702-pm-domain.c b/arch/arm/mach-zx/zx296702-pm-domain.c
> index 7a08bf9d..ac44ea8 100644
> --- a/arch/arm/mach-zx/zx296702-pm-domain.c
> +++ b/arch/arm/mach-zx/zx296702-pm-domain.c
> @@ -169,10 +169,8 @@ static int zx296702_pd_probe(struct platform_device *pdev)
>  	}
>  
>  	pcubase = devm_ioremap_resource(&pdev->dev, res);
> -	if (IS_ERR(pcubase)) {
> -		dev_err(&pdev->dev, "ioremap fail.\n");
> +	if (IS_ERR(pcubase))
>  		return -EIO;
> -	}
>  
>  	for (i = 0; i < ARRAY_SIZE(zx296702_pm_domains); ++i)
>  		pm_genpd_init(zx296702_pm_domains[i], NULL, false);
> -- 
> 1.9.1
> 
> 
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives