linux-kernel - Re: [PATCH 09/25] vfs: Allow mount information to be queried by fsinfo() [ver #13]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <18849.1560866430@warthog.procyon.org.uk>
Date:   Tue, 18 Jun 2019 15:00:30 +0100
From:   David Howells <dhowells@...hat.com>
To:     Joel Fernandes <joel@...lfernandes.org>
Cc:     dhowells@...hat.com, viro@...iv.linux.org.uk, raven@...maw.net,
        linux-api@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org, mszeredi@...hat.com
Subject: Re: [PATCH 09/25] vfs: Allow mount information to be queried by fsinfo() [ver #13]

Joel Fernandes <joel@...lfernandes.org> wrote:

> > +	record.mnt_id = m->mnt_id;
> > +	record.notify_counter = atomic_read(&m->mnt_notify_counter);
> > +	store_mount_fsinfo(params, &record);
> > +
> > +	rcu_read_unlock();
> 
> Not super familiar with this code, but wanted to check with you:
> 
> Here, if the rcu_read_lock is supposed to protect the RCU list, can
> rcu_read_lock() scope be reduced to just wrapping around the
> list_for_each_entry_rcu?

Done.

David