linux-kernel - Re: [PATCH][next] netfilter: synproxy: ensure zero is returned on non-error return path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 18 Jun 2019 15:15:03 +0100
From:   Colin Ian King <colin.king@...onical.com>
To:     Pablo Neira Ayuso <pablo@...filter.org>,
        Jozsef Kadlecsik <kadlec@...filter.org>,
        Florian Westphal <fw@...len.de>,
        "David S . Miller" <davem@...emloft.net>,
        netfilter-devel@...r.kernel.org, coreteam@...filter.org,
        netdev@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] netfilter: synproxy: ensure zero is returned on
 non-error return path

On 18/06/2019 15:13, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Currently function nf_synproxy_ipv6_init returns an uninitialized
> garbage value in variable ret on a successful return.  Fix this by
> returning zero on success.
> 
> Addresses-Coverity: ("Uninitialized scalar variable")
> Fixes: d7f9b2f18eae ("netfilter: synproxy: extract SYNPROXY infrastructure from {ipt, ip6t}_SYNPROXY")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  net/netfilter/nf_synproxy_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/netfilter/nf_synproxy_core.c b/net/netfilter/nf_synproxy_core.c
> index 50677285f82e..701f880d01e6 100644
> --- a/net/netfilter/nf_synproxy_core.c
> +++ b/net/netfilter/nf_synproxy_core.c
> @@ -1223,7 +1223,7 @@ nf_synproxy_ipv6_init(struct synproxy_net *snet, struct net *net)
>  	}
>  
>  	snet->hook_ref6++;
> -	return err;
> +	return 0;
>  }
>  EXPORT_SYMBOL_GPL(nf_synproxy_ipv6_init);
>  
> 
Scratch that, I've noticed the same issue in the ipv4 code too. I'll
send a V2.