linux-kernel - Re: [PATCH] arm64/sve: fix genksyms generation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a2NQSm3sPcJq=6=Espa5da_L+2RNtyS=jkkzD3tx-4ehA@mail.gmail.com>
Date:   Tue, 18 Jun 2019 16:15:55 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Will Deacon <will.deacon@....com>
Cc:     Ard Biesheuvel <ard.biesheuvel@...aro.org>,
        Catalin Marinas <catalin.marinas@....com>,
        Dave Martin <Dave.Martin@....com>,
        Alex Bennée <alex.bennee@...aro.org>,
        Peter Maydell <peter.maydell@...aro.org>,
        Alan Hayward <alan.hayward@....com>,
        Julien Grall <julien.grall@....com>,
        Marc Zyngier <marc.zyngier@....com>,
        Mark Rutland <mark.rutland@....com>,
        Andrew Murray <andrew.murray@....com>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arm64/sve: fix genksyms generation

On Tue, Jun 18, 2019 at 2:03 PM Will Deacon <will.deacon@....com> wrote:
>
> From 6e004b8824d4eb6a4e61cd794fbc3a761b50135b Mon Sep 17 00:00:00 2001
> From: Will Deacon <will.deacon@....com>
> Date: Tue, 18 Jun 2019 12:56:49 +0100
> Subject: [PATCH] genksyms: Teach parse about __uint128_t built-in type
>
> __uint128_t crops up in a few files that export symbols to modules, so
> teach genksyms about it so that we don't end up skipping the CRC
> generation for some symbols due to the parser failing to spot them:
>
>   | WARNING: EXPORT symbol "kernel_neon_begin" [vmlinux] version
>   |          generation failed, symbol will not be versioned.
>   | ld: arch/arm64/kernel/fpsimd.o: relocation R_AARCH64_ABS32 against
>   |     `__crc_kernel_neon_begin' can not be used when making a shared
>   |     object
>   | ld: arch/arm64/kernel/fpsimd.o:(.data+0x0): dangerous relocation:
>   |     unsupported relocation
>
> Cc: Ard Biesheuvel <ard.biesheuvel@...aro.org>
> Reported-by: Arnd Bergmann <arnd@...db.de>
> Signed-off-by: Will Deacon <will.deacon@....com>

Looks good to me,

Acked-by: Arnd Bergmann <arnd@...db.de>

I've added this to my randconfig build setup, replacing my earlier
patch, and will let you know if any problems with it remain.

         Arnd