linux-kernel - Re: [Linux-kernel-mentees] [PATCH v2] fs: cramfs_fs.h: Fix shifting signed 32-bit value by 31 bits problem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190618163835.GA4766@arch>
Date:   Tue, 18 Jun 2019 22:08:37 +0530
From:   Puranjay Mohan <puranjay12@...il.com>
To:     Shuah Khan <skhan@...uxfoundation.org>
Cc:     hch@...radead.org, linux-kernel-mentees@...ts.linuxfoundation.org,
        linux-kernel@...r.kernel.org, gregkh@...uxfoundation.org
Subject: Re: [Linux-kernel-mentees] [PATCH v2] fs: cramfs_fs.h: Fix shifting
 signed 32-bit value by 31 bits problem

On Tue, Jun 18, 2019 at 10:15:11AM -0600, Shuah Khan wrote:
> On 6/18/19 10:08 AM, Greg KH wrote:
> > On Tue, Jun 18, 2019 at 05:19:47PM +0530, Puranjay Mohan wrote:
> > > Fix CRAMFS_BLK_FLAG_UNCOMPRESSED to use "U" cast to avoid shifting signed
> > > 32-bit value by 31 bits problem. This isn't a problem for kernel builds
> > > with gcc.
> > > 
> > > This could be problem since this header is part of public API which
> > > could be included for builds using compilers that don't handle this
> > > condition safely resulting in undefined behavior.
> > > 
> > > Signed-off-by: Puranjay Mohan <puranjay12@...il.com>
> > 
> > Reviewed-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > 
> > You should resend this and cc: Nicolas Pitre <nico@...xnic.net> as he is
> > the cramfs maintainer.
> > 
> 
> Puranjay! You can add all the Reviewed-by tags when you resend the patch
> with Nicolas Pitre <nico@...xnic.net> on the thread.
> 
> 
> Reviewed-by: Shuah Khan <skhan@...uxfoundation.org>
> 
> thanks,
> -- Shuah

Thanks, I have sent the mail with Nicolas Pitre in CC.

--Puranjay