lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 18 Jun 2019 11:42:40 +0800 From: Herbert Xu <herbert@...dor.apana.org.au> To: Arnd Bergmann <arnd@...db.de> Cc: Philipp Reisner <philipp.reisner@...bit.com>, Lars Ellenberg <lars.ellenberg@...bit.com>, Jens Axboe <axboe@...nel.dk>, Roland Kammerer <roland.kammerer@...bit.com>, Eric Biggers <ebiggers@...gle.com>, "Gustavo A. R. Silva" <gustavo@...eddedor.com>, Kees Cook <keescook@...omium.org>, drbd-dev@...ts.linbit.com, linux-block <linux-block@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] drbd: dynamically allocate shash descriptor On Mon, Jun 17, 2019 at 10:58:58PM +0200, Arnd Bergmann wrote: > > The warning is gone with this patch. Instead of 1280 bytes for drbd_receiver, > I now see 512 bytes, and 768 bytes for drbd_get_response, everything else is > under 160 bytes in this file. > > However, with the call chain of > > drbd_receiver > conn_connect > drbd_do_auth > drbd_get_response > > This still adds up to as much as before, so it only shuts up the > warning but does not reduce the maximum stack usage. OK so it doesn't really reduce it. Let's just go with your patch. Thanks, -- Email: Herbert Xu <herbert@...dor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Powered by blists - more mailing lists