linux-kernel - Re: [PATCH v3 -next] firmware: ti_sci: Fix gcc unused-but-set-variable warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3111974c-2052-498c-303e-f953a599be6c@oracle.com>
Date:   Tue, 18 Jun 2019 21:35:42 -0700
From:   "santosh.shilimkar@...cle.com" <santosh.shilimkar@...cle.com>
To:     Suman Anna <s-anna@...com>, YueHaibing <yuehaibing@...wei.com>,
        nm@...com, t-kristo@...com, ssantosh@...nel.org
Cc:     linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v3 -next] firmware: ti_sci: Fix gcc
 unused-but-set-variable warning

On 6/17/19 11:41 AM, Suman Anna wrote:
> On 6/15/19 7:50 AM, YueHaibing wrote:
>> Fixes gcc '-Wunused-but-set-variable' warning:
>>
>> drivers/firmware/ti_sci.c: In function ti_sci_cmd_ring_config:
>> drivers/firmware/ti_sci.c:2035:17: warning: variable dev set but not used [-Wunused-but-set-variable]
>> drivers/firmware/ti_sci.c: In function ti_sci_cmd_ring_get_config:
>> drivers/firmware/ti_sci.c:2104:17: warning: variable dev set but not used [-Wunused-but-set-variable]
>> drivers/firmware/ti_sci.c: In function ti_sci_cmd_rm_udmap_tx_ch_cfg:
>> drivers/firmware/ti_sci.c:2287:17: warning: variable dev set but not used [-Wunused-but-set-variable]
>> drivers/firmware/ti_sci.c: In function ti_sci_cmd_rm_udmap_rx_ch_cfg:
>> drivers/firmware/ti_sci.c:2357:17: warning: variable dev set but not used [-Wunused-but-set-variable]
>>
>> Use the 'dev' variable instead of info->dev to fix this.
>>
>> Reported-by: Hulk Robot <hulkci@...wei.com>
>> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> 
> Acked-by: Suman Anna <s-anna@...com>
> 
> Hi Santosh,
> Can you pick up this patch, goes on top of your for_5.3/driver-soc branch?
> 
Applied.